Skip to content

remove usages of #readOptionalStreamable, #readStreamableList. #44578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2019
Merged

remove usages of #readOptionalStreamable, #readStreamableList. #44578

merged 1 commit into from
Jul 18, 2019

Conversation

talevy
Copy link
Contributor

@talevy talevy commented Jul 18, 2019

This commit removes references to Streamable from StreamInput.

This is all a part of the effort to remove Streamable usage.

relates #34389.

@talevy
remove usages of #readOptionalStreamable, #readStreamableList.
ca69876 
This commit removes references to Streamable from StreamInput.

This is all a part of the effort to remove Streamable usage.

relates elastic#34389.
@talevy talevy added :Core/Infra/Core Core issues without another label >refactoring v8.0.0 v7.4.0 labels Jul 18, 2019
@talevy talevy requested review from rjernst and jtibshirani July 18, 2019 17:00
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

jtibshirani
jtibshirani approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@jtibshirani jtibshirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@talevy talevy merged commit bbe97b0 into elastic:master Jul 18, 2019
@talevy talevy deleted the removestreaminputstreamable branch July 18, 2019 20:31
@talevy talevy mentioned this pull request Jul 18, 2019
Merged
talevy added a commit that referenced this pull request Jul 18, 2019
@talevy
remove usages of #readOptionalStreamable, #readStreamableList. (#44578)…
03f5084 
… (#44598)

This commit removes references to Streamable from StreamInput.

This is all a part of the effort to remove Streamable usage.

relates #34389.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtibshirani jtibshirani jtibshirani approved these changes

@rjernst rjernst Awaiting requested review from rjernst

Assignees
No one assigned
Labels
:Core/Infra/Core Core issues without another label >refactoring v7.4.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@talevy @elasticmachine @jtibshirani @jakelandis