Use debug logging instead for Azure tests #44672
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These Azure tests have hard println statements which means we always see these messages during configuration. Yet, there are unnecessary most of the time. This commit changes them to use debug logging.
jasontedor
added
>non-issue
:Distributed Coordination/Snapshot/Restore
|
Pinging @elastic/es-distributed |
|
This removes these statements which always appear during configuration: Perhaps these log messages are not needed at all, but this PR takes the conservative approach of assuming they are needed, but not dumping them to the console in configuration for every build. |
original-brownbear
approved these changes
Jul 22, 2019
There was a problem hiding this comment.
@jasontedor thanks! These were actually put in place to verify that the 3rd party tests on CI are correctly configured. I don't think that's necessary anymore (the 3rd party tests work now and with recent changes we have other ways of verifying what credentials are used anyway). Feel free to just remove this logging if you want.
jasontedor
added a commit
that referenced
this pull request
Jul 22, 2019
These Azure tests have hard println statements which means we always see these messages during configuration. Yet, there are unnecessary most of the time. This commit changes them to use debug logging.
jasontedor
added a commit
that referenced
this pull request
Jul 22, 2019
These Azure tests have hard println statements which means we always see these messages during configuration. Yet, there are unnecessary most of the time. This commit changes them to use debug logging.
jasontedor
added a commit
that referenced
this pull request
Jul 22, 2019
This commit removes some unneeded debugging logging statements from the Azure storage tests. Relates #44672
jasontedor
added a commit
that referenced
this pull request
Jul 22, 2019
This commit removes some unneeded debugging logging statements from the Azure storage tests. Relates #44672
jasontedor
added a commit
that referenced
this pull request
Jul 22, 2019
This commit removes some unneeded debugging logging statements from the Azure storage tests. Relates #44672
|
I pushed 56d47d0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These Azure tests have hard println statements which means we always see these messages during configuration. Yet, there are unnecessary most of the time. This commit changes them to use debug logging.