Skip to content

[ML] [7.x] Only emit deprecation warning if there was actual change of a datafeed's job_id. #44755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2019

Conversation

przemekwitek
Copy link
Contributor

There is no need to emit deprecation warning if the DatafeedUpdate has job_id that is equal to the current job_id in DatafeedConfig.

Related to #44691

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@przemekwitek przemekwitek merged commit 26da573 into elastic:7.x Jul 24, 2019
@przemekwitek przemekwitek deleted the deprecation_of_job_id_change branch July 24, 2019 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants