Convert logging related gradle classes to java #44771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit converts the logging related classes (only used for vagrant) to java from groovy. relates elastic#34459
rjernst
added
:Delivery/Build
|
Pinging @elastic/es-core-infra |
mark-vieira
approved these changes
Jul 23, 2019
|
|
||
| @Override | ||
| public void close() { | ||
| progressLogger.completed(); |
There was a problem hiding this comment.
We might want to call flush() here just in case the parent caller doesn't. Same goes with the other logger impl.
| * There is a Tap4j project but we can't use it because it wants to parse the | ||
| * entire TAP stream at once and won't parse it stream-wise. | ||
| */ | ||
| public class TapLoggerOutputStream extends LoggingOutputStream { |
There was a problem hiding this comment.
I had to do some googling to find out what "tap" is. Can we perhaps elaborate here in the javadoc on that, and even link to https://testanything.org?
| } else { | ||
| // otherwise extend the buffer | ||
| final int newBufferLength = buffer.length + DEFAULT_BUFFER_LENGTH; | ||
| final byte[] newBuffer = new byte[newBufferLength]; |
There was a problem hiding this comment.
This can be simplified a bit with Arrays.copyOf()
rjernst
added a commit
that referenced
this pull request
Jul 24, 2019
This commit converts the logging related classes (only used for vagrant) to java from groovy. relates #34459
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit converts the logging related classes (only used for vagrant)
to java from groovy.
relates #34459