Skip to content

Persist DatafeedTimingStats with RefreshPolicy.NONE by default #44940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

przemekwitek
Copy link
Contributor

@przemekwitek przemekwitek commented Jul 29, 2019

This PR makes DatafeedTimingStats document persisted with RefreshPolicy.NONE by default. RefreshPolicy.IMMEDIATE is only used on datafeed stop action.

Related to: #44792

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@przemekwitek przemekwitek force-pushed the defer_persisting_timing_stats branch 2 times, most recently from 8e791e0 to 7752540 Compare July 29, 2019 09:23
@przemekwitek
Copy link
Contributor Author

run elasticsearch-ci/2

@przemekwitek przemekwitek removed the WIP label Jul 29, 2019
@przemekwitek przemekwitek marked this pull request as ready for review July 29, 2019 11:19
@przemekwitek przemekwitek added :ml Machine learning and removed :ml Machine learning labels Jul 29, 2019
@przemekwitek przemekwitek force-pushed the defer_persisting_timing_stats branch from 7752540 to 246a47c Compare August 1, 2019 07:01
@przemekwitek przemekwitek force-pushed the defer_persisting_timing_stats branch from 246a47c to 11f33d5 Compare August 1, 2019 07:25
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left one suggestion.

Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@przemekwitek
Copy link
Contributor Author

run elasticsearch-ci/2

@przemekwitek przemekwitek merged commit 5a78d3c into elastic:master Aug 1, 2019
@przemekwitek przemekwitek deleted the defer_persisting_timing_stats branch August 1, 2019 09:47
przemekwitek added a commit to przemekwitek/elasticsearch that referenced this pull request Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants