Correct a code snippet in removal_of_types. #45118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the reindex examples did not include `_doc` as the destination type. This would result in the reindex failing with the error "Rejecting mapping update to [users] as the final mapping would have more than 1 type: [_doc, user]".
jtibshirani
added
>docs
|
Pinging @elastic/es-docs |
|
Pinging @elastic/es-search |
|
@elasticmachine test this please |
pcsanwald
approved these changes
Aug 6, 2019
|
Thanks for the review! Right, I will backport to 6.7 and 6.8 at least. |
jtibshirani
added a commit
that referenced
this pull request
Aug 6, 2019
Previously, the reindex examples did not include `_doc` as the destination type. This would result in the reindex failing with the error "Rejecting mapping update to [users] as the final mapping would have more than 1 type: [_doc, user]". Relates to #43100.
jtibshirani
added a commit
that referenced
this pull request
Aug 6, 2019
Previously, the reindex examples did not include `_doc` as the destination type. This would result in the reindex failing with the error "Rejecting mapping update to [users] as the final mapping would have more than 1 type: [_doc, user]". Relates to #43100.
jtibshirani
added a commit
that referenced
this pull request
Aug 6, 2019
Previously, the reindex examples did not include `_doc` as the destination type. This would result in the reindex failing with the error "Rejecting mapping update to [users] as the final mapping would have more than 1 type: [_doc, user]". Relates to #43100.
jtibshirani
added a commit
that referenced
this pull request
Aug 6, 2019
Previously, the reindex examples did not include `_doc` as the destination type. This would result in the reindex failing with the error "Rejecting mapping update to [users] as the final mapping would have more than 1 type: [_doc, user]". Relates to #43100.
jtibshirani
added a commit
that referenced
this pull request
Aug 6, 2019
Previously, the reindex examples did not include `_doc` as the destination type. This would result in the reindex failing with the error "Rejecting mapping update to [users] as the final mapping would have more than 1 type: [_doc, user]". Relates to #43100.
jtibshirani
added a commit
that referenced
this pull request
Aug 6, 2019
Previously, the reindex examples did not include `_doc` as the destination type. This would result in the reindex failing with the error "Rejecting mapping update to [users] as the final mapping would have more than 1 type: [_doc, user]". Relates to #43100.
jtibshirani
added a commit
that referenced
this pull request
Aug 6, 2019
Previously, the reindex examples did not include `_doc` as the destination type. This would result in the reindex failing with the error "Rejecting mapping update to [users] as the final mapping would have more than 1 type: [_doc, user]". Relates to #43100.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the reindex examples did not include
_docas the destinationtype. On 6.x this would result in the reindex failing with the error "Rejecting
mapping update to [users] as the final mapping would have more than 1 type:
[_doc, user]".
Relates to #43100.