-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Implement ml/data_frame/analytics/_estimate_memory_usage API endpoint #45188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2400192
to
0e6a285
Compare
0e6a285
to
b2a07db
Compare
Pinging @elastic/ml-core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this - I know it's a lot of changes for what seems like it should be simple functionality.
I just left a few minor comments and questions.
...gin/core/src/main/java/org/elasticsearch/xpack/core/ml/action/EstimateMemoryUsageAction.java
Outdated
Show resolved
Hide resolved
...n/core/src/main/java/org/elasticsearch/xpack/core/ml/dataframe/DataFrameAnalyticsConfig.java
Outdated
Show resolved
Hide resolved
9e27f96
to
0b29277
Compare
Jenkins run elasticsearch-ci/1 |
744ccef
to
bdb45bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the CI is passing
run elasticsearch-ci/2 |
This reverts commit 77af46370605f9291ef05c5bf08ba4a21df20868.
…test cases from build.gradle as possible.
7a69527
to
9c9f76f
Compare
…nse's fields optional.
* Add unit tests for AbstractNativeProcess
This PR introduces ml/data_frame/analytics/_estimate_memory_usage API endpoint that will be used to obtain memory usage estimation even before the analysis gets started.
Relates #44699