Improve SCM info in build scans #45264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Vieira <[email protected]>
|
Pinging @elastic/es-core-infra |
Signed-off-by: Mark Vieira <[email protected]>
Signed-off-by: Mark Vieira <[email protected]>
rjernst
approved these changes
Aug 6, 2019
| @@ -18,26 +18,32 @@ buildScan { | |||
| value 'Jenkins Worker Label', it | |||
| } | |||
|
|
|||
| def isPrBuild = System.getenv('ROOT_BUILD_CAUSE_GHPRBCAUSE') != null | |||
There was a problem hiding this comment.
This can be boolean, no need for def?
| link 'Source', "https://github.com/elastic/elasticsearch/tree/${System.getenv('ghprbActualCommit')}" | ||
| link 'Pull Request', System.getenv('ghprbPullLink') | ||
| } else { | ||
| def branch = System.getenv('GIT_BRANCH').split('/').last() |
There was a problem hiding this comment.
This can be String, no need for def?
mark-vieira
added a commit
that referenced
this pull request
Aug 7, 2019
mark-vieira
added a commit
that referenced
this pull request
Aug 7, 2019
lcawl
pushed a commit
to lcawl/elasticsearch
that referenced
this pull request
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes usage of the Nebula SCM plugin info for decorating build scans. This information tended to be quite inaccurate in many scenarios so instead we just use known Jenkins environment variables for these things. We also include some additional information exposed by Jenkins for pull requests such as the PR number, target branch and link back to the original PR.