More read-only-allow-delete docs #45320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds to the `index.blocks.read_only_allow_delete` docs the information that this block may be added or removed automatically, and rewords the breaking-changes docs to mention the blocks explicitly and to recommend using a different block. Relates elastic#42559
DaveCTurner
added
>docs
|
Pinging @elastic/es-distributed |
|
Pinging @elastic/es-docs |
original-brownbear
approved these changes
Aug 8, 2019
| some distance below the flood-stage watermark and therefore the disk space | ||
| problem is truly resolved. Since this block may be automatically removed, you | ||
| can no longer rely on adding this block manually to prevent writes to an index. | ||
| You should use the `index.blocks.read_only` block instead. This behaviour can |
There was a problem hiding this comment.
NIT: I know it was there before but behaviour -> behavior because we tend to do it the 🇺🇸 way in docs? (I'm sorry)
There was a problem hiding this comment.
$ git annotate docs/reference/migration/migrate_7_4.asciidoc | grep behav
d73e2f9c5601 (Armin Braun 2019-07-15 10:21:54 +0200 68)If your application requires handling `+` as a single space you can return to the old behaviour by setting the system property
d73e2f9c5601 (Armin Braun 2019-07-15 10:21:54 +0200 69)`es.rest.url_plus_as_space` to `true`. Note that this behaviour is deprecated and setting this system property to `true` will cease
b47f74818634 (David Turner 2019-08-08 08:48:36 +0100 113)You should use the `index.blocks.read_only` block instead. This behaviour can
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds to the
index.blocks.read_only_allow_deletedocs the information thatthis block may be added or removed automatically, and rewords the
breaking-changes docs to mention the blocks explicitly and to recommend using a
different block.
Relates #42559