Skip to content

[DOCS] Reformats cat recovery API #45345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2019
Merged

[DOCS] Reformats cat recovery API #45345

merged 2 commits into from
Aug 12, 2019

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Aug 8, 2019

@jrodewig jrodewig added >docs General docs changes :Data Management/CAT APIs Text APIs behind /_cat v8.0.0 v7.4.0 v7.3.1 labels Aug 8, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment--not sure if the example is missing or was moved & the text needs to be updated accordingly.

As an example, here is what the recovery state of a cluster may look like when
there are no shards in transit from one node to another:


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an example missing here?

(I also twitch over "may" vs "might" ... I would reflexively use might because "may implies permission". But that's one of those editorial stickles where the distinction doesn't really matter to most readers.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this @debadair. I intended to remove this sentence entirely. Removed with c7f88d6.

The example has been moved to https://github.com/elastic/elasticsearch/pull/45345/files#diff-0e907dfad62124d1dc58267b446d2c51R61

@jrodewig jrodewig requested a review from debadair August 9, 2019 18:41
Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrodewig jrodewig merged commit 6ba11f6 into master Aug 12, 2019
@jrodewig jrodewig deleted the cat-recovery-reformat branch August 12, 2019 12:17
jrodewig added a commit that referenced this pull request Aug 12, 2019
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants