Skip to content

[DOCS] Reformat index API. #45415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 12, 2019
Merged

[DOCS] Reformat index API. #45415

merged 7 commits into from
Aug 12, 2019

Conversation

debadair
Copy link
Contributor

@debadair debadair commented Aug 10, 2019

This PR updates the doc index API to align with the new API reference template.

Relates to elastic/docs#937 and #45365

A few questions wrt applying the API Ref template and terminology:

  • How are we handling cases where particular path params are mutually exclusive? For example, the typical usage is PUT /<index>/_doc/<_id>, but you can specify PUT /<index>/_create/<_id> to get the put if absent behavior.
  • Related, how do we talk about _whatever params--as "endpoints", paths, something else?
  • How do we want to refer to the doc _id? Always as _id, ID, doc ID, doc _id?

@debadair debadair added >docs General docs changes :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. v8.0.0 v7.0.2 v7.1.2 v7.4.0 v7.3.1 v7.2.2 labels Aug 10, 2019
@debadair debadair requested a review from jrodewig August 10, 2019 00:00
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@jrodewig
Copy link
Contributor

How are we handling cases where particular path params are mutually exclusive? For example, the typical usage is PUT //_doc/<_id>, but you can specify PUT //_create/<_id> to get the put if absent behavior.

I would document both endpoints in the Request section. You can note mutually exclusive path params in the param definitions. You can also note this in the long-form Description section.

Related, how do we talk about _whatever params--as "endpoints", paths, something else?

If you need to refer to them, "resource" would be the most common term. "Endpoint" usually refers to the entire URL.

How do we want to refer to the doc _id? Always as _id, ID, doc ID, doc _id?

I think _id is appropriate here as that's also the meta field used to return document IDs. We can use document ID if we're referring to the value, not the field or param.

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a few comments, but nothing blocking.

@debadair
Copy link
Contributor Author

Fixed the broken link with: elastic/elasticsearch-hadoop#1331

@debadair debadair merged commit 009020f into elastic:master Aug 12, 2019
@jrodewig jrodewig removed the v7.0.2 label Aug 22, 2019
debadair added a commit that referenced this pull request Aug 22, 2019
* [DOCS] Reformat index API.

* Incorporated review feedback.
debadair added a commit that referenced this pull request Aug 22, 2019
* [DOCS] Reformat index API.

* Incorporated review feedback.
debadair added a commit that referenced this pull request Aug 22, 2019
debadair added a commit that referenced this pull request Aug 23, 2019
* [DOCS] Reformat index API.

* Incorporated review feedback.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >docs General docs changes v7.3.1 v7.4.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants