Reindex search resiliency #45497
Merged
Reindex search resiliency #45497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Local reindex can now survive loosing data nodes that contain source data. The original query will be restarted with a filter for `_seq_no >= last_seq_no` when a failure is detected. Part of elastic#42612 and split out from elastic#43187
henningandersen
added
>enhancement
v8.0.0
:Distributed Indexing/Reindex
|
Pinging @elastic/es-distributed |
|
I will take a look at this tomorrow. |
Tim-Brooks
reviewed
Aug 16, 2019
| @@ -135,7 +136,9 @@ | |||
| this.listener = listener; | |||
| BackoffPolicy backoffPolicy = buildBackoffPolicy(); | |||
| bulkRetry = new Retry(BackoffPolicy.wrap(backoffPolicy, worker::countBulkRetry), threadPool); | |||
| scrollSource = buildScrollableResultSource(backoffPolicy); | |||
| // todo: this is trappy, since if a subclass override relies on subclass fields, they are not initialized. We should fix | |||
There was a problem hiding this comment.
I agree. This was causing me problems in a recent PR.
…_search_resiliency
No longer retry/restart the original search request, since this is not what we used to do and it leads to long wait time to get the info back that a search request is bad.
|
Thanks @tbrooks8 and sorry for not fixing the test failure before now. It should be ready for another round (provided tests succeed). |
No longer fail on the empty index. So far we consider this a workaround/hack more than the solution.
Use unmapped_type to circumvent problem with newly created indices without a mapping, since this is local to reindex. Once type removal is complete, ensuring that the metadata fields are always available likely becomes easier, so we will defer a solution to the search/sort problem.
|
@elasticmachine run elasticsearch-ci/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local reindex can now survive loosing data nodes that contain source
data. The original query will be restarted with a filter for
_seq_no >= last_seq_nowhen a failure is detected.Part of #42612 and split out from #43187
A couple of follow-ups will be done (all indicated with todos) in addition to what is in the meta issue:
allowPartialSearchResultin masterScrollableHitSourceseparately rather than in super constructor.