transport.publish_address should contain CNAME #45626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrershov
added
>bug
:Distributed Coordination/Network
|
Pinging @elastic/es-distributed |
original-brownbear
approved these changes
Aug 15, 2019
| @@ -77,17 +97,35 @@ public void writeTo(StreamOutput out) throws IOException { | |||
| static final String PROFILES = "profiles"; | |||
| } | |||
|
|
|||
| private String getPublishAddressString(String propertyName, TransportAddress publishAddress){ | |||
There was a problem hiding this comment.
NIT: maybe rather name this formatPublishAddressString, it's really weird if something is named get... and then used to print another object's properties :)
andrershov
pushed a commit
that referenced
this pull request
Aug 16, 2019
andrershov
pushed a commit
that referenced
this pull request
Aug 22, 2019
…erty is specified (#45662) Follow-up of #45626. Now we always output transport.publish_address with CNAME and log deprecation warning if es.transport.cname_in_publish_address property is specified. This commit also adds a test which will fail once Elasticsearch version is changed to 9, to make sure we remove the property when doing reversioning. Closes #39970
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds CNAME reporting for transport.publish_address same way it's done for http.publish_address.
Relates #32806
Relates #39970