Skip to content

[ML] Remove timeout on waiting for DF analytics result processor to complete #45724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dimitris-athanasiou
Copy link
Contributor

We cannot know how long the analysis will take to complete thus we should not have
a timeout. Note that if the process crashes, the result processor will pick the
exception due to the stream closing.

Closes #45723

…omplete

We cannot know how long the analysis will take to complete thus we should not have
a timeout. Note that if the process crashes, the result processor will pick the
exception due to the stream closing.

Closes elastic#45723
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

Copy link
Contributor

@przemekwitek przemekwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dimitris-athanasiou dimitris-athanasiou merged commit 70baf0d into elastic:master Aug 20, 2019
@dimitris-athanasiou dimitris-athanasiou deleted the remove-30-minute-timeout-for-df-analytics-process branch August 20, 2019 12:18
dimitris-athanasiou added a commit to dimitris-athanasiou/elasticsearch that referenced this pull request Aug 20, 2019
… to complete (elastic#45724)

We cannot know how long the analysis will take to complete thus we should not have
a timeout. Note that if the process crashes, the result processor will pick the
exception due to the stream closing.

Closes elastic#45723
dimitris-athanasiou added a commit that referenced this pull request Aug 20, 2019
… to complete (#45724) (#45733)

We cannot know how long the analysis will take to complete thus we should not have
a timeout. Note that if the process crashes, the result processor will pick the
exception due to the stream closing.

Closes #45723
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] DF Analytics times out after 30 minutes
4 participants