Skip to content

Implement AvgAggregatorTests#testDontCacheScripts and remove AvgIT #45737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

csoulios
Copy link
Contributor

Similar to PR #45030 integration test testDontCacheScripts() was moved to unit test AvgAggregatorTests#testDontCacheScripts.

AvgIT class was removed.

@csoulios csoulios added >test Issues or PRs that are addressing/adding tests :Analytics/Aggregations Aggregations >refactoring v8.0.0 v7.4.0 labels Aug 20, 2019
@csoulios csoulios requested a review from polyfractal August 20, 2019 13:07
@csoulios csoulios self-assigned this Aug 20, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo

Copy link
Contributor

@polyfractal polyfractal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Hooray for removing an integration test 🎉

@csoulios csoulios merged commit 0f024c1 into elastic:master Aug 20, 2019
@csoulios csoulios deleted the refactor_avgit_test branch August 20, 2019 14:52
csoulios added a commit to csoulios/elasticsearch that referenced this pull request Aug 20, 2019
… tests (elastic#45737)

Similar to PR elastic#45030 integration test testDontCacheScripts() was moved to unit test AvgAggregatorTests#testDontCacheScripts.

AvgIT class was removed.
csoulios added a commit that referenced this pull request Aug 20, 2019
…gIT #45746

Backports PR #45737:

    Similar to PR #45030 integration test testDontCacheScripts() was moved to unit test AvgAggregatorTests#testDontCacheScripts.

    AvgIT class was removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations >refactoring >test Issues or PRs that are addressing/adding tests v7.4.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants