Skip to content

Increase timeout for relocation tests #46554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 11, 2019

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Sep 10, 2019

There's nothing wrong in the logs from these failures. I think 30 seconds might not be enough to relocate shards with many documents as CI is quite slow. This change increases the timeout to 60 seconds for these relocation tests. It also dumps the hot threads in case of timed out.

Closes #46526
Closes #46439

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. v8.0.0 v7.5.0 v7.4.1 labels Sep 10, 2019
@dnhatn dnhatn requested a review from tlrx September 10, 2019 16:55
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of this @dnhatn

Copy link
Member

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2 :)thanks @dnhatn !

@dnhatn
Copy link
Member Author

dnhatn commented Sep 11, 2019

Thanks @tlrx and @original-brownbear.

@dnhatn dnhatn merged commit 16ac1b1 into elastic:master Sep 11, 2019
@dnhatn dnhatn deleted the increase-timeout-relocation-test branch September 11, 2019 14:34
dnhatn added a commit that referenced this pull request Sep 12, 2019
There's nothing wrong in the logs from these failures. I think 30
seconds might not be enough to relocate shards with many documents as CI
is quite slow. This change increases the timeout to 60 seconds for these
relocation tests. It also dumps the hot threads in case of timed out.

Closes #46526
Closes #46439
dnhatn added a commit that referenced this pull request Sep 12, 2019
There's nothing wrong in the logs from these failures. I think 30
seconds might not be enough to relocate shards with many documents as CI
is quite slow. This change increases the timeout to 60 seconds for these
relocation tests. It also dumps the hot threads in case of timed out.

Closes #46526
Closes #46439
@colings86 colings86 added v7.4.0 and removed v7.4.1 labels Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. >test Issues or PRs that are addressing/adding tests v7.4.0 v7.5.0 v8.0.0-alpha1
Projects
None yet
6 participants