Skip to content

[Java.time] Support partial parsing #46814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2019

Conversation

pgomulka
Copy link
Contributor

@pgomulka pgomulka commented Sep 18, 2019

Enable partial parsing of date part. This is making the behaviour in java.time implementation the same as with joda.
2018, 2018-01 and 2018-01-01 are all valid dates for date_optional_time or strict_date_optional_time
closes #45284
closes #47473

@pgomulka pgomulka added WIP :Core/Infra/Core Core issues without another label labels Sep 18, 2019
@pgomulka pgomulka self-assigned this Sep 18, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@pgomulka pgomulka force-pushed the feature/partial_parsing2 branch from c351638 to 6055a82 Compare October 7, 2019 08:41
@pgomulka pgomulka removed the WIP label Oct 7, 2019
@pgomulka pgomulka marked this pull request as ready for review October 7, 2019 10:40
@pgomulka pgomulka requested a review from rjernst October 7, 2019 10:41
@niemyjski
Copy link
Contributor

Any idea when 7.5.0 will be released (weeks/months)? This is somewhat of a blocker for us migrating off 5.x

@pgomulka
Copy link
Contributor Author

pgomulka commented Oct 9, 2019

@elasticmachine update branch

@pgomulka
Copy link
Contributor Author

pgomulka commented Oct 9, 2019

@elasticmachine run elasticsearch-ci/packaging-sample-matrix

@pgomulka
Copy link
Contributor Author

@niemyjski it is really hard to tell, could be either weeks/month. You can always try to workaround with your own custom date format.

@niemyjski
Copy link
Contributor

I don't want to have to do this on every date field that I have, and then have to reindex every index when this fix is out.

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgomulka pgomulka merged commit eddffda into elastic:master Oct 10, 2019
pgomulka added a commit to pgomulka/elasticsearch that referenced this pull request Oct 10, 2019
Enable partial parsing of date part. This is making the behaviour in java.time implementation the same as with joda.
2018, 2018-01 and 2018-01-01 are all valid dates for date_optional_time or strict_date_optional_time
closes elastic#45284
closes elastic#47473
pgomulka added a commit that referenced this pull request Oct 11, 2019
Enable partial parsing of date part. This is making the behaviour in java.time implementation the same as with joda.
2018, 2018-01 and 2018-01-01 are all valid dates for date_optional_time or strict_date_optional_time
closes #45284
closes #47473
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BREAKING CHANGE - Range Query by Date Year returns no results Date field does not support partial dates anymore
6 participants