-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Update AWS SDK for repository-s3 plugin to support IAM Roles for Service Accounts #46969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pinging @elastic/es-distributed |
@seanmcrw thanks for opening this PR. You'll have to run |
Jenkins test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @seanmcrw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry my bad ... we don't want to diverge between S3 and the EC2 discovery here.
Can you update the dep. version in the EC2 discovery (discovery-ec2
plugin) to the same value you used here please as well?
Thanks
No problem. discovery-ec2 plugin updated |
Jenkins test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks @seanmcrw !
…ice Accounts (elastic#46969) * Update AWS SDK for repository-s3 and discovery-ec2 plugins
Hi, any idea when this will be released? |
@seanmcrw this is labelled |
No description provided.