Skip to content

Update AWS SDK for repository-s3 plugin to support IAM Roles for Service Accounts #46969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 24, 2019

Conversation

seanmcrw
Copy link
Contributor

No description provided.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@original-brownbear
Copy link
Member

@seanmcrw thanks for opening this PR. You'll have to run ./gradlew updateSHAs and commit the result to make a dependency upgrade work though. Can you do that please?
You can verify that everything worked out correctly by ensuring that ./gradlew precommit passes.

@original-brownbear
Copy link
Member

Jenkins test this

Copy link
Member

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @seanmcrw

Copy link
Member

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry my bad ... we don't want to diverge between S3 and the EC2 discovery here.

Can you update the dep. version in the EC2 discovery (discovery-ec2 plugin) to the same value you used here please as well?
Thanks

@seanmcrw
Copy link
Contributor Author

No problem. discovery-ec2 plugin updated ./gradlew updateSHAs run and passed.

@original-brownbear
Copy link
Member

Jenkins test this

Copy link
Member

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @seanmcrw !

@original-brownbear original-brownbear merged commit 9c266cd into elastic:master Sep 24, 2019
original-brownbear pushed a commit to original-brownbear/elasticsearch that referenced this pull request Sep 24, 2019
…ice Accounts (elastic#46969)

* Update AWS SDK for repository-s3 and discovery-ec2 plugins
original-brownbear added a commit that referenced this pull request Sep 24, 2019
…ice Accounts (#46969) (#47004)

* Update AWS SDK for repository-s3 and discovery-ec2 plugins
@seanmcrw
Copy link
Contributor Author

Hi, any idea when this will be released?
Thanks

@original-brownbear
Copy link
Member

@seanmcrw this is labelled 7.5.0 so it'll be released in that version. I can't give you an exact release date for that though I'm afraid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants