excluding all fields of an object should not remove parent. #4717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When excluding '*.f1' from `{ "obj": { "f1": 1, "f2": 2 } }` XContentMapValues.filter returns `{ "obj": { "f2": 2}}`. When run on `{ "obj": { "f1" : 1 }}` we should return `{ "obj": { }}` to maintain object structure. People currently need to always check whether `obj` is there or not.
Closes elastic#4715
Closes elastic#4047
Related to elastic#4491
…one place for clarity.
|
@imotov thx for the review. Made the change you suggested it reads clearer. |
|
LGTM |
|
Pushed to: f2710c1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When excluding '*.f1' from
{ "obj": { "f1": 1, "f2": 2 } }XContentMapValues.filter returns{ "obj": { "f2": 2}}. When run on{ "obj": { "f1" : 1 }}we should return{ "obj": { }}to maintain object structure. People currently need to always check whetherobjis there or not.Closes #4715
Closes #4047
Related to #4491