-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Fix AD realm additional metadata #47179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
albertzaharovits
merged 4 commits into
elastic:master
from
albertzaharovits:fix-ad-realm-additional-metadata
Oct 1, 2019
Merged
Fix AD realm additional metadata #47179
albertzaharovits
merged 4 commits into
elastic:master
from
albertzaharovits:fix-ad-realm-additional-metadata
Oct 1, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/es-security |
bizybot
approved these changes
Oct 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you.
There are some compilation errors but the change look good to me.
jkakavas
approved these changes
Oct 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on green CI
albertzaharovits
added a commit
to albertzaharovits/elasticsearch
that referenced
this pull request
Oct 1, 2019
Due to a regression bug the metadata Active Directory realm setting is ignored (it works correctly for the LDAP realm type). This commit redresses it. Closes elastic#45848
This was referenced Oct 1, 2019
albertzaharovits
added a commit
that referenced
this pull request
Oct 1, 2019
Due to a regression bug the metadata Active Directory realm setting is ignored (it works correctly for the LDAP realm type). This commit redresses it. Closes #45848
albertzaharovits
added a commit
that referenced
this pull request
Oct 1, 2019
Due to a regression bug the metadata Active Directory realm setting is ignored (it works correctly for the LDAP realm type). This commit redresses it. Closes #45848
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
Oct 2, 2019
The changes introduced in elastic#47179 made it so that we could try to build an SSLContext with verification mode set to None, which is not allowed in FIPS 140 JVMs. This commit address that
jkakavas
added a commit
that referenced
this pull request
Oct 3, 2019
The changes introduced in #47179 made it so that we could try to build an SSLContext with verification mode set to None, which is not allowed in FIPS 140 JVMs. This commit address that
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
Oct 3, 2019
The changes introduced in elastic#47179 made it so that we could try to build an SSLContext with verification mode set to None, which is not allowed in FIPS 140 JVMs. This commit address that
jkakavas
added a commit
that referenced
this pull request
Oct 3, 2019
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
Oct 12, 2019
The changes introduced in elastic#47179 made it so that we could try to build an SSLContext with verification mode set to None, which is not allowed in FIPS 140 JVMs. This commit address that
jkakavas
added a commit
that referenced
this pull request
Oct 12, 2019
39 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>bug
:Security/Authentication
Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc)
v7.4.1
v7.5.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a regression bug the
metadata
Active Directory realm setting is ignored (it works correctly for the LDAP realm type). This commit redresses it.Closes #45848