Keep nodes above watermark in testAutomaticReleaseOfIndexBlock #47387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today the comment boldly claims that this line of code keeps nodes above the 10-byte low watermark when in fact this is not true at all. This change fixes this so that it really does keep nodes above the low watermark. Fixes elastic#45338. Again.
DaveCTurner
added
>test
|
Pinging @elastic/es-distributed |
DaveCTurner
added a commit
that referenced
this pull request
Oct 1, 2019
Today the comment boldly claims that this line of code keeps nodes above the 10-byte low watermark when in fact this is not true at all. This change fixes this so that it really does keep nodes above the low watermark. Fixes #45338. Again.
DaveCTurner
added a commit
that referenced
this pull request
Oct 1, 2019
Today the comment boldly claims that this line of code keeps nodes above the 10-byte low watermark when in fact this is not true at all. This change fixes this so that it really does keep nodes above the low watermark. Fixes #45338. Again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today the comment boldly claims that this line of code keeps nodes above the
10-byte low watermark when in fact this is not true at all. This change fixes
this so that it really does keep nodes above the low watermark.
Fixes #45338. Again.