Introduce simple remote connection strategy #47480

Tim-Brooks · 2019-10-02T23:45:32Z

This commit introduces a simple remote connection strategy which will
open remote connections to a configurable list of user supplied
addresses. These addresses can be remote Elasticsearch nodes or
intermediate proxies. We will perform normal clustername and version
validation, but otherwise rely on the remote cluster to route requests
to the appropriate remote node.

elasticmachine · 2019-10-02T23:45:33Z

Pinging @elastic/es-distributed (:Distributed/Network)

ywelsch

Thanks for the PR. I've left some suggestions for code simplification

server/src/main/java/org/elasticsearch/transport/SimpleConnectionStrategy.java

server/src/test/java/org/elasticsearch/transport/SimpleConnectionStrategyTests.java

…nection_strategy

Tim-Brooks · 2019-10-08T02:53:07Z

@ywelsch i updated this PR for your comments.

ywelsch

I've left some nits, otherwise looking good.

ywelsch · 2019-10-08T11:39:40Z

server/src/main/java/org/elasticsearch/transport/RemoteConnectionStrategy.java

@@ -161,4 +166,19 @@ boolean assertNoRunningConnections() {
        }
        return result;
    }
+
+    static Predicate<ClusterName> getRemoteClusterNamePredicate(ClusterName remoteClusterName) {


this is only used by SniffConnectionStrategy now. Move it back down?

ywelsch · 2019-10-08T11:40:06Z

server/src/main/java/org/elasticsearch/transport/SimpleConnectionStrategy.java

+
+    private void performSimpleConnectionProcess(Iterator<Supplier<TransportAddress>> addressIter, ActionListener<Void> listener) {
+        openConnections(listener, 1);
+


extra newline

ywelsch · 2019-10-08T11:40:35Z

server/src/main/java/org/elasticsearch/transport/SimpleConnectionStrategy.java

+        } else {
+            int openConnections = connectionManager.size();
+            if (openConnections == 0) {
+                finished.onFailure(new IllegalStateException("Unable to open any simple connections to remote cluster"));


mention remote cluster name here?

ywelsch · 2019-10-08T11:40:51Z

server/src/main/java/org/elasticsearch/transport/SimpleConnectionStrategy.java

+            if (openConnections == 0) {
+                finished.onFailure(new IllegalStateException("Unable to open any simple connections to remote cluster"));
+            } else {
+                logger.trace("unable to open maximum number of connections [opened: {}, maximum: {}]", openConnections,


mention remote cluster name here, and log at debug level?

trace is for expected things, debug for more unusual stuff

ywelsch · 2019-10-08T11:43:35Z

server/src/main/java/org/elasticsearch/transport/SimpleConnectionStrategy.java

+
+                    @Override
+                    public void onFailure(Exception e) {
+                        logger.debug(() -> new ParameterizedMessage("failed to open remote connection to address {}", address), e);


mention cluster name here

ywelsch · 2019-10-08T11:49:26Z

server/src/main/java/org/elasticsearch/transport/SimpleConnectionStrategy.java

+        return resolvedAddresses.get(Math.floorMod(curr, resolvedAddresses.size()));
+    }
+
+    private ConnectionManager.ConnectionValidator clusterNameValidator(DiscoveryNode node) {


let's remove the node parameter here and have a single instance of the ConnectionValidator initialized in the constructor. The node here is not that useful, and you can get it from the connection (newConnection.getNode()).

This commit introduces a simple remote connection strategy which will open remote connections to a configurable list of user supplied addresses. These addresses can be remote Elasticsearch nodes or intermediate proxies. We will perform normal clustername and version validation, but otherwise rely on the remote cluster to route requests to the appropriate remote node.

* Extract remote "sniffing" to connection strategy (#47253) Currently the connection strategy used by the remote cluster service is implemented as a multi-step sniffing process in the RemoteClusterConnection. We intend to introduce a new connection strategy that will operate in a different manner. This commit extracts the sniffing logic to a dedicated strategy class. Additionally, it implements dedicated tests for this class. Additionally, in previous commits we moved away from a world where the remote cluster connection was mutable. Instead, when setting updates are made, the connection is torn down and rebuilt. We still had methods and tests hanging around for the mutable behavior. This commit removes those. * Introduce simple remote connection strategy (#47480) This commit introduces a simple remote connection strategy which will open remote connections to a configurable list of user supplied addresses. These addresses can be remote Elasticsearch nodes or intermediate proxies. We will perform normal clustername and version validation, but otherwise rely on the remote cluster to route requests to the appropriate remote node. * Make remote setting updates support diff strategies (#47891) Currently the entire remote cluster settings infrastructure is designed around the sniff strategy. As we introduce an additional conneciton strategy this infrastructure needs to be modified to support it. This commit modifies the code so that the strategy implementations will tell the service if the connection needs to be torn down and rebuilt. As part of this commit, we will wait 10 seconds for new clusters to connect when they are added through the "update" settings infrastructure. * Make remote setting updates support diff strategies (#47891) Currently the entire remote cluster settings infrastructure is designed around the sniff strategy. As we introduce an additional conneciton strategy this infrastructure needs to be modified to support it. This commit modifies the code so that the strategy implementations will tell the service if the connection needs to be torn down and rebuilt. As part of this commit, we will wait 10 seconds for new clusters to connect when they are added through the "update" settings infrastructure.

fpytloun · 2019-12-06T17:39:36Z

This is great feature, thank you.
Can you please post example configuration to switch existing setup to using simple strategy?

Tim-Brooks · 2019-12-06T22:10:08Z

@fpytloun The meta issue is here #49067. As you can see, the work is scoped for 7.6 although things can always change.

Currently the "simple" work is currently available on either 7.6 or 8.0 snapshot builds.

It can be configured:

// If you do not configure a mode, it will default to the existing sniff implementation
cluster.remote.test_remote_cluster.mode: "simple"
cluster.remote.test_remote_cluster.simple.addresses: ["address:port"]

Please note that it is still in active development. For example, we are still debating whether we want to name it "simple" or "proxy" (the primary advantage of this mode over sniff is for routing through a proxy to unaddressable nodes).

You can follow any updates on the meta issue and the documentation will be updated before any release where this feature is GA.

Tim-Brooks added 2 commits October 2, 2019 14:23

WIP

9efa296

Tests

84d3f81

Tim-Brooks added >enhancement WIP :Distributed Coordination/Network Http and internode communication implementations v8.0.0 v7.5.0 labels Oct 2, 2019

Tim-Brooks changed the title ~~Introduce simple remote conneciton strategy~~ Introduce simple remote connection strategy Oct 2, 2019

Tim-Brooks requested a review from ywelsch October 3, 2019 16:59

ywelsch suggested changes Oct 7, 2019

View reviewed changes

Tim-Brooks added 3 commits October 7, 2019 09:28

Merge remote-tracking branch 'upstream/master' into simple_remote_con…

fb70efd

…nection_strategy

Review changes

74a5748

Review changes

ba2fc95

Tim-Brooks requested a review from ywelsch October 8, 2019 01:01

ywelsch approved these changes Oct 8, 2019

View reviewed changes

Changes

95ce8fd

Tim-Brooks merged commit 98611e7 into elastic:master Oct 8, 2019

Tim-Brooks added backport pending and removed WIP labels Oct 8, 2019

Tim-Brooks mentioned this pull request Oct 24, 2019

Multiple remote connection strategy support #48496

Merged

Tim-Brooks removed the backport pending label Oct 25, 2019

Tim-Brooks mentioned this pull request Nov 14, 2019

Implement a remote proxy connection mode #49067

Open

16 tasks

Tim-Brooks deleted the simple_remote_connection_strategy branch April 30, 2020 18:25

jakelandis removed the v8.0.0 label Jul 26, 2021

jakelandis added the v8.0.0-alpha1 label Jul 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce simple remote connection strategy #47480

Introduce simple remote connection strategy #47480

Tim-Brooks commented Oct 2, 2019

elasticmachine commented Oct 2, 2019

ywelsch left a comment

Tim-Brooks commented Oct 8, 2019

ywelsch left a comment

ywelsch Oct 8, 2019

ywelsch Oct 8, 2019

ywelsch Oct 8, 2019

ywelsch Oct 8, 2019

ywelsch Oct 8, 2019

ywelsch Oct 8, 2019

fpytloun commented Dec 6, 2019

Tim-Brooks commented Dec 6, 2019


		private void performSimpleConnectionProcess(Iterator<Supplier<TransportAddress>> addressIter, ActionListener<Void> listener) {
		openConnections(listener, 1);

Introduce simple remote connection strategy #47480

Introduce simple remote connection strategy #47480

Conversation

Tim-Brooks commented Oct 2, 2019

elasticmachine commented Oct 2, 2019

ywelsch left a comment

Choose a reason for hiding this comment

Tim-Brooks commented Oct 8, 2019

ywelsch left a comment

Choose a reason for hiding this comment

ywelsch Oct 8, 2019

Choose a reason for hiding this comment

ywelsch Oct 8, 2019

Choose a reason for hiding this comment

ywelsch Oct 8, 2019

Choose a reason for hiding this comment

ywelsch Oct 8, 2019

Choose a reason for hiding this comment

ywelsch Oct 8, 2019

Choose a reason for hiding this comment

ywelsch Oct 8, 2019

Choose a reason for hiding this comment

fpytloun commented Dec 6, 2019

Tim-Brooks commented Dec 6, 2019