Skip to content

Fix windows packaging tests #47554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Conversation

alpar-t
Copy link
Contributor

@alpar-t alpar-t commented Oct 4, 2019

On windows, it happens that the process we called terminates but some
other process it creates still has the same output strems and thus the
files open, so we can't clean it up.

This PR makes the cleanup a best effort.

On windows, it happens that the process we called terminates but some
other process it creates still has the same output strems and thus the
files open, so we can't clean it up.

This PR makes the cleanup a best effort.
@alpar-t alpar-t added :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts v8.0.0 v7.5.0 labels Oct 4, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Packaging)

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems extreme to do for all commands we run on windows within packaging tests. If there is a child process created by some command, why are we not waiting on that child?

@alpar-t
Copy link
Contributor Author

alpar-t commented Oct 4, 2019

@rjernst AFAIK this happens when we run elasticsearch -d so we don't actually want to wait. This caused a lot of problems as it was previously causing the test to hang.
If it's ok with you I would like to look at this in a follow-up. At least we'll have the logs to see where it's happening.
My goal is to get the tests passing to be able to add PR checks to make sure the proper care will be taken not to break them.
That will make exploring additional changes easier too, right now testing everything before opening a PR is manual and takes a lot of time.

@alpar-t
Copy link
Contributor Author

alpar-t commented Oct 4, 2019

I'm going to merge this to prevent CI failures and hopefully get some successful runs over the weekend. Will act on any feedback following that.

@alpar-t alpar-t merged commit 2b0b092 into elastic:master Oct 4, 2019
@alpar-t alpar-t deleted the fix-windows-packaging branch October 4, 2019 11:02
alpar-t added a commit that referenced this pull request Oct 4, 2019
On windows, it happens that the process we called terminates but some
other process it creates still has the same output strems and thus the
files open, so we can't clean it up.

This PR makes the cleanup a best effort.
@jimczi jimczi added the >test Issues or PRs that are addressing/adding tests label Nov 12, 2019
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts Team:Delivery Meta label for Delivery team >test Issues or PRs that are addressing/adding tests v7.5.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants