Skip to content

Fix Rollover error when alias has closed indices #47839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

gwbrown
Copy link
Contributor

@gwbrown gwbrown commented Oct 9, 2019

Rollover previously requested index stats for all indices in the
provided alias, which causes an exception when there is a closed index
with that alias.

This commit adjusts the IndicesOptions used on the index stats
request so that closed indices are ignored, rather than throwing
an exception.

This is mostly a backport of #47148, but the behavior is slightly
different: If the write index is closed, rollover will throw an
exception, as 6.8 cannot retrieve index stats for closed indices.

…tic#47539)

Rollover previously requested index stats for all indices in the
provided alias, which causes an exception when there is a closed index
with that alias.

This commit adjusts the IndicesOptions used on the index stats
request so that closed indices are ignored, rather than throwing
an exception.

This is mostly a backport of elastic#47148, but the behavior is slightly
different: If the write index is closed, rollover will throw an
exception, as 6.8 cannot retrieve index stats for closed indices.
@gwbrown gwbrown added >bug :Data Management/Indices APIs APIs to create and manage indices and templates v6.8.4 labels Oct 9, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Indices APIs)

@gwbrown gwbrown requested a review from dakrone October 9, 2019 23:53
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gwbrown
Copy link
Contributor Author

gwbrown commented Oct 10, 2019

Build timed out.
@elasticmachine run elasticsearch-ci/2

@gwbrown gwbrown merged commit 98e80e6 into elastic:6.8 Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Data Management/Indices APIs APIs to create and manage indices and templates v6.8.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants