Make the run task honor tests.es properties #47860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes elastic#47797 With this PR we now again honor tests.es and tests.heap.size
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
| entry -> entry.getKey().toString().substring(CUSTOM_SETTINGS_PREFIX.length()), | ||
| entry -> entry.getValue().toString() | ||
| )); | ||
| System.err.println(additionalSettings.toString()); |
There was a problem hiding this comment.
Was this intended?
There was a problem hiding this comment.
No it was not, I'm going to remove it
alpar-t
added a commit
that referenced
this pull request
Oct 11, 2019
* Make the run task honor tests.es properties Closes #47797 With this PR we now again honor tests.es and tests.heap.size * remove debuging
howardhuanghua
pushed a commit
to TencentCloudES/elasticsearch
that referenced
this pull request
Oct 14, 2019
* Make the run task honor tests.es properties Closes elastic#47797 With this PR we now again honor tests.es and tests.heap.size * remove debuging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #47797
With this PR we now again honor tests.es and tests.heap.size