-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[DOCS] Remove unsupported local
and master_timeout
parms from cat API docs
#47933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/es-core-features (:Core/Features/CAT APIs) |
Pinging @elastic/es-docs (>docs) |
local
parm from several cat APIslocal
and master_timeout
parms from unsupported cat APIs
local
and master_timeout
parms from unsupported cat APIslocal
and master_timeout
parms from cat APIs
local
and master_timeout
parms from cat APIslocal
and master_timeout
parms from cat API docs
dakrone
requested changes
Oct 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dakrone
approved these changes
Oct 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but actually pushing the right button this time.
jrodewig
added a commit
that referenced
this pull request
Oct 14, 2019
jrodewig
added a commit
that referenced
this pull request
Oct 14, 2019
jrodewig
added a commit
that referenced
this pull request
Oct 14, 2019
Mpdreamz
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Nov 19, 2019
And document them as deprecated relates: elastic/elasticsearch#47933
Mpdreamz
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Nov 20, 2019
* update specs * update ignore list * sync docgen changes from master, ignore time enum for now since its values are descriptions and we already have a Time type * codegen line ending changes * Add back local/master_timeout And document them as deprecated relates: elastic/elasticsearch#47933 * do not generate time and byte querystring parameters * patch now also hoists params over, we can no longer rely on simple merge since we temporarily still rework the spec files in memory to the old format * add changes and remove bytes for now * Add back force as option for version_type Mark as obsolete to warn the user but without breaking backwards compatibily. The 7.5 client should be able to be used against < 7.5 server. relates: github.com/elastic/elasticsearch/pull/47228 * codegen for enums can now pragma disable obsolete members in generated GetString() * Generated pragma disable for obsolete enum members
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Data Management/CAT APIs
Text APIs behind /_cat
>docs
General docs changes
v7.3.3
v7.4.1
v7.5.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes documentation for the
local
parameter from the following cat APIs:Removes the
master_timeout
parameter from the following cat APIs:These parameters are unsupported in the listed APIs.
Closes #45843