Update forbiddenapis to v2.7 #47969
Merged
Update forbiddenapis to v2.7 #47969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
|
@elasticmachine test this please |
alpar-t
approved these changes
Oct 15, 2019
There was a problem hiding this comment.
Thanks @uschindler I'we been meaning to check on this for some time now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just updates forbiddenapis to 2.7. This new version supports 12 and Java 13.
Features:
FileReaderandFileWritersince Java 11 (new constructor with charset available)I commented the code about maximum runtime java version, as Gradle currently only supports Java 12, so forbiddenapis is always able to apply signatures.
Nevertheless, I don't understand the logic here. targetVersion should be identical to the targetVersion used during compile (Java 11), it makes no sense to use a newer version as this makes builds not reproducible. But this is a different issue, so somebody should explain to me why this is done. The correct way is to set
forbidden.targetCompatiblity := javac.targetCompatibility