Skip to content

[ML] Parse and index inference model #48016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dimitris-athanasiou
Copy link
Contributor

This adds parsing an inference model as a possible
result of the analytics process. When we do parse such a model
we persist a TrainedModelConfig into the inference index
that contains additional metadata derived from the running job.

This adds parsing an inference model as a possible
result of the analytics process. When we do parse such a model
we persist a `TrainedModelConfig` into the inference index
that contains additional metadata derived from the running job.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

@benwtrent benwtrent self-requested a review October 14, 2019 18:21
Copy link
Member

@benwtrent benwtrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also include doc_type field in the .ml-inference-* mapping and have the TrainedModelConfig write trained_mode_config to that field when serialized for storage.

@dimitris-athanasiou
Copy link
Contributor Author

@benwtrent I pushed a commit addressing all your spot-on comments!

Copy link
Member

@benwtrent benwtrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more minor things, but they can be fixed later if pushed for time :)

@dimitris-athanasiou
Copy link
Contributor Author

@elasticmachine update branch

@dimitris-athanasiou
Copy link
Contributor Author

run elasticsearch-ci/packaging-sample

@dimitris-athanasiou dimitris-athanasiou merged commit 2f73fd4 into elastic:master Oct 15, 2019
@dimitris-athanasiou dimitris-athanasiou deleted the parse-and-index-inference-model branch October 15, 2019 15:05
benwtrent pushed a commit to benwtrent/elasticsearch that referenced this pull request Oct 16, 2019
This adds parsing an inference model as a possible
result of the analytics process. When we do parse such a model
we persist a `TrainedModelConfig` into the inference index
that contains additional metadata derived from the running job.
benwtrent added a commit that referenced this pull request Oct 16, 2019
This adds parsing an inference model as a possible
result of the analytics process. When we do parse such a model
we persist a `TrainedModelConfig` into the inference index
that contains additional metadata derived from the running job.
@dimitris-athanasiou
Copy link
Contributor Author

Backport to 7.x done in 0dddbb5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants