Skip to content

[DOCS] minor fix to documentation: http.host can't default to itself #48135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 14, 2019
Merged

[DOCS] minor fix to documentation: http.host can't default to itself #48135

merged 3 commits into from
Nov 14, 2019

Conversation

SylvainJuge
Copy link
Member

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@jrodewig jrodewig changed the title minor fix to documentation: http.host can't default to itself [DOCS] minor fix to documentation: http.host can't default to itself Oct 17, 2019
@jrodewig jrodewig added :Distributed Coordination/Network Http and internode communication implementations >docs General docs changes v7.4.2 v7.5.0 v7.6.0 v8.0.0 labels Oct 17, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Network)

@polyfractal polyfractal added v7.4.3 and removed v7.4.2 labels Oct 31, 2019
@jimczi jimczi removed the v7.5.0 label Nov 12, 2019
DaveCTurner
DaveCTurner requested changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested deleting the mention of the default entirely -- see below.

There is a similar bug in the docs for transport.host. Would you fix that too?

@SylvainJuge
Copy link
Member Author

@DaveCTurner I've applied the same change for transport.host.

DaveCTurner
DaveCTurner approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SylvainJuge SylvainJuge merged commit 7072941 into elastic:master Nov 14, 2019
@SylvainJuge SylvainJuge deleted the fix-doc-typo-http-host branch November 14, 2019 14:56
SylvainJuge added a commit that referenced this pull request Nov 14, 2019
@SylvainJuge
[DOCS] minor fix to documentation: http.host can't default to itself (#…
43f91a3 
…48135)

fix minor typos on http.host and transport.host default values.

7.4 backport of #48135
SylvainJuge added a commit that referenced this pull request Nov 14, 2019
@SylvainJuge
[DOCS] minor fix to documentation: http.host can't default to itself (#…
d116f82 
…48135)

fix minor typos on http.host and transport.host default values.

7.5 backport of #48135
SylvainJuge added a commit that referenced this pull request Nov 14, 2019
@SylvainJuge
[DOCS] minor fix to documentation: http.host can't default to itself (#…
e8f49cd 
…48135)

fix minor typos on http.host and transport.host default values.

7.x backport of #48135
@SylvainJuge
Copy link
Member Author

backport to 7.4

backport to 7.5

backport to 7.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaveCTurner DaveCTurner DaveCTurner approved these changes

Assignees
No one assigned
Labels
:Distributed Coordination/Network Http and internode communication implementations >docs General docs changes v7.4.3 v7.5.0 v7.6.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SylvainJuge @elasticmachine @DaveCTurner @jakelandis @polyfractal @jimczi @jrodewig