Skip to content

Clarify mapping types that support ignore_malformed #48206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 18, 2019

Conversation

cbuescher
Copy link
Member

The ignore_malformed setting only works on selected mapping types, otherwise
we throw an mapper_parsing_exception. We should add a list of all the mapping
types that support it, since the number of types not supporting it seems larger.

Closes #47166

The `ignore_malformed` setting only works on selected mapping types, otherwise
we throw an mapper_parsing_exception. We should add a list of all the mapping
types that support it, since the number of types not supporting it seems larger.

Closes elastic#47166
@cbuescher cbuescher added >docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types v8.0.0 v7.5.0 v7.6.0 labels Oct 17, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Mapping)

[[ignore-malformed-setting]]
==== Index-level default

The `index.mapping.ignore_malformed` setting can be set on the index level to
allow to ignore malformed content globally across all mapping types.
allow to ignore malformed content globally across all mapping types that allow it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
allow to ignore malformed content globally across all mapping types that allow it.
to ignore malformed content globally across all allowed mapping types.

Comment on lines 50 to 55
* <<number>>:: `long`, `integer`, `short`, `byte`, `double`, `float`, `half_float`, `scaled_float`
* <<date>>:: `date`
* <<date_nanos>>:: `date_nanos`
* <<geo-point>>:: `geo_point` for lat/lon points
* <<geo-shape>>:: `geo_shape` for complex shapes like polygons
* <<ip>>:: `ip` for IPv4 and IPv6 addresses
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't render properly in the output:

def-output

If you want a bulleted list, you can try this instead (note the added new line):

The `ignore_malformed` setting is currently supported by the following <<mapping-types,mapping types>>:

* <<number>>: `long`, `integer`, `short`, `byte`, `double`, `float`, `half_float`, `scaled_float`
* <<date>>: `date`
* <<date_nanos>>: `date_nanos`
* <<geo-point>>: `geo_point` for lat/lon points
* <<geo-shape>>: `geo_shape` for complex shapes like polygons
* <<ip>>: `ip` for IPv4 and IPv6 addresses

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I left one comment about a needed formatting fix.

Christoph Büscher added 2 commits October 18, 2019 19:22
@cbuescher cbuescher merged commit c60139a into elastic:master Oct 18, 2019
cbuescher pushed a commit that referenced this pull request Oct 18, 2019
The `ignore_malformed` setting only works on selected mapping types, otherwise
we throw an mapper_parsing_exception. We should add a list of all the mapping
types that support it, since the number of types not supporting it seems larger.

Closes #47166
cbuescher pushed a commit that referenced this pull request Oct 18, 2019
The `ignore_malformed` setting only works on selected mapping types, otherwise
we throw an mapper_parsing_exception. We should add a list of all the mapping
types that support it, since the number of types not supporting it seems larger.

Closes #47166
cbuescher pushed a commit that referenced this pull request Oct 18, 2019
The `ignore_malformed` setting only works on selected mapping types, otherwise
we throw an mapper_parsing_exception. We should add a list of all the mapping
types that support it, since the number of types not supporting it seems larger.

Closes #47166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types v7.4.2 v7.5.0 v7.6.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore_malformed enabled by default and cannot be disabled on fields of type completion
4 participants