Read build and runtime java from properties file #48355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes the PS1 script that starts os tests for the packaging test matrix to match the bash script we use on Linux in terms of reading the runtime and build java versions. Relates to elastic/infra#11593
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
mark-vieira
approved these changes
Oct 22, 2019
| # $env:ES_BUILD_JAVA="java12" | ||
| #$env:ES_RUNTIME_JAVA="java11" | ||
| $AppProps = ConvertFrom-StringData (Get-Content .ci/java-versions.properties -raw) | ||
| $env:ES_BUILD_JAVA=$AppProps.ES_BUILD_JAVA |
There was a problem hiding this comment.
Is there some generic way to just expose these environment variables so we don't have to hard code each of them? For example, loop over $AppProps and set each as a corresponding environment variable so we don't have to touch this script should we add something new to java-versions.properties?
There was a problem hiding this comment.
I considered it, but don't really see a need to make this very generic.
This has the advantage of being simple and readable. I suggest we change ti if we'll have to add one more.
|
@elasticmachine run |
alpar-t
added a commit
that referenced
this pull request
Oct 23, 2019
This PR changes the PS1 script that starts os tests for the packaging test matrix to match the bash script we use on Linux in terms of reading the runtime and build java versions. Relates to elastic/infra#11593
alpar-t
added a commit
that referenced
this pull request
Oct 23, 2019
This PR changes the PS1 script that starts os tests for the packaging test matrix to match the bash script we use on Linux in terms of reading the runtime and build java versions. Relates to elastic/infra#11593
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the PS1 script that starts os tests for the packaging
test matrix to match the bash script we use on Linux in terms of reading
the runtime and build java versions.
Relates to elastic/infra#11593