Skip to content

Add populate_user_metadata in OIDC realm #48357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 24, 2019
Merged

Add populate_user_metadata in OIDC realm #48357

merged 5 commits into from
Oct 24, 2019

Conversation

jkakavas
Copy link
Member

Resolves: #48217

@jkakavas jkakavas added >bug :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) v8.0.0 v7.5.0 labels Oct 22, 2019
@jkakavas jkakavas requested a review from bizybot October 22, 2019 14:25
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (:Security/Authentication)

@jkakavas
Copy link
Member Author

@elasticmachine update branch

bizybot
bizybot approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@bizybot bizybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

...urity/src/test/java/org/elasticsearch/xpack/security/authc/oidc/OpenIdConnectRealmTests.java Outdated
@@ -90,6 +89,8 @@ public void testAuthentication() throws Exception {
if (notPopulateMetadata == false) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: better to test for true scenario given the name of the variable.

@jkakavas
Copy link
Member Author 

08:16:58 * What went wrong:
08:16:58 Execution failed for task ':test:fixtures:krb5kdc-fixture:composeUp'.
08:16:58 > Exit-code 1 when calling /usr/local/bin/docker-compose, stdout: N/A

@jkakavas
Copy link
Member Author

@elasticmachine run elasticsearch-ci/1

@jkakavas jkakavas merged commit 1ef61a5 into elastic:master Oct 24, 2019
jkakavas added a commit to jkakavas/elasticsearch that referenced this pull request Oct 24, 2019
@jkakavas
Add populate_user_metadata in OIDC realm (elastic#48357)
45e542a 
Make populate_user_metadata configuration parameter
available in the OpenID Connect authentication realm

Resolves: elastic#48217
@jkakavas jkakavas mentioned this pull request Oct 24, 2019
Merged
jkakavas added a commit to jkakavas/elasticsearch that referenced this pull request Oct 24, 2019
@jkakavas
Add populate_user_metadata in OIDC realm (elastic#48357)
58d78c2 
Make populate_user_metadata configuration parameter
available in the OpenID Connect authentication realm

Resolves: elastic#48217
@jkakavas jkakavas mentioned this pull request Oct 24, 2019
Merged
jkakavas added a commit that referenced this pull request Oct 24, 2019
@jkakavas
Add populate_user_metadata in OIDC realm (#48357) (#48438)
c6b733f 
Make populate_user_metadata configuration parameter
available in the OpenID Connect authentication realm

Resolves: #48217
jkakavas added a commit that referenced this pull request Oct 24, 2019
@jkakavas
Add populate_user_metadata in OIDC realm (#48357) (#48439)
d86a2fc 
Make populate_user_metadata configuration parameter
available in the OpenID Connect authentication realm

Resolves: #48217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bizybot bizybot bizybot approved these changes

Assignees
No one assigned
Labels
>bug :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) v7.5.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenID Connect realm is missing populate_user_metadata property
4 participants
@jkakavas @elasticmachine @bizybot @jakelandis