-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Increase timeouts for packaging tests #48528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is in preparation to move to nested virtualization which is much slower than the bare metal setup we use right now, but parallelizes better resulting in a net win.t
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one small ask
private static final long waitTime = TimeUnit.SECONDS.toMillis(60); | ||
private static final long timeoutLength = TimeUnit.SECONDS.toMillis(10); | ||
// generous timeout as nested virtualization can be quite slow ... | ||
private static final long waitTime = TimeUnit.MINUTES.toMillis(3); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we only set the longer timeout when running nested?
@elasticmachine run elasticsearch-ci/packaging-sample-matrix |
This is in preparation to move to nested virtualization which is much slower than the bare metal setup we use right now, but parallelizes better resulting in a net win.t
This is in preparation to move to nested virtualization which is much slower than the bare metal setup we use right now, but parallelizes better resulting in a net win.t
This is in preparation to move to nested virtualization which is much slower
than the bare metal setup we use right now, but parallelizes better
resulting in a net win.t