Skip to content

Cleanup Redundant Futures in Recovery Code #48805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

original-brownbear
Copy link
Member

Follow up to #48110 cleaning up the redundant future
uses that were left over from that change.

Follow up to elastic#48110 cleaning up the redundant future
uses that were left over from that change.
@original-brownbear original-brownbear added >non-issue :Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. v8.0.0 v7.6.0 labels Nov 1, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Recovery)

Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @original-brownbear.

@original-brownbear
Copy link
Member Author

Thanks Nhat!

@original-brownbear original-brownbear merged commit 6742d9c into elastic:master Nov 2, 2019
@original-brownbear original-brownbear deleted the async-recovery-cleanups branch November 2, 2019 14:41
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Nov 2, 2019
Follow up to elastic#48110 cleaning up the redundant future
uses that were left over from that change.
original-brownbear added a commit that referenced this pull request Nov 2, 2019
Follow up to #48110 cleaning up the redundant future
uses that were left over from that change.
@original-brownbear original-brownbear restored the async-recovery-cleanups branch August 6, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. >non-issue v7.6.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants