Remove Blocking Connect Methods from TransportService #48841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're not doing any blocking connects in production code anymore so we can move these helpers to test code only. Also, we were only tracking the proper closing of blockingly opened connections on the mock transport service but didn't check those created via the non-blocking API which is fixed here too.
original-brownbear
added
>non-issue
:Core/Infra/Transport API
|
Pinging @elastic/es-core-infra (:Core/Infra/Transport API) |
ywelsch
added
:Distributed Coordination/Network
|
Pinging @elastic/es-distributed (:Distributed/Network) |
pugnascotia
approved these changes
Nov 4, 2019
|
Thanks @pugnascotia ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're not doing any blocking connects in production code anymore
so we can move these helpers to test code only.
Also, we were only tracking the proper closing of blockingly opened
connections on the mock transport service but didn't check those
created via the non-blocking API which is fixed here too.