Skip to content

[DOCS] Reformat update license API docs #48967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2019
Merged

[DOCS] Reformat update license API docs #48967

merged 1 commit into from
Nov 14, 2019

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Nov 11, 2019

Consistently uses the PUT HTTP method in all example snippets for the update license API docs. While both PUT and POST are supported, PUT is a bit more RESTful. Closes #35341.

Makes a few other changes to better align the API docs with the API reference template.

Changes

  • Replaces POST with PUT in several snippet examples.

  • Removes leading slashes (/) from all snippets. Per the ES UI team, this is (slightly) more preferred as it reduces the likelihood of double slashes (//), which will produce an error.

  • Relocates and retitles the 'Authorization' section to 'Prerequisites'.

  • Replaces explicit titles with the appropriate API reference template attributes.

  • Replaces unneeded [float] tags with explicit anchors.

Makes a few changes to better align the update license API docs with
the [API reference template][0].

Changes:

* Replaces POST with PUT in several snippet examples.
  While both are valid, PUT is a bit more RESTful.

* Removes leading slashes (/) from all snippets.

* Relocates and retitles the 'Authorization' section to 'Prerequisites'.

* Replaces explicit titles with the appropriate API reference template
  attributes.

* Replaces unneeded `[float]` tags with explicit anchors.

Closes #35341

[0]: https://github.com/elastic/docs/blob/master/shared/api-ref-ex.asciidoc
@jrodewig jrodewig added >docs General docs changes :Security/License License functionality for commercial features v8.0.0 v7.5.0 v7.6.0 v7.4.3 labels Nov 11, 2019
@jrodewig jrodewig requested review from jasontedor and lcawl November 11, 2019 21:26
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (:Security/License)

@jimczi jimczi removed the v7.5.0 label Nov 12, 2019
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jrodewig jrodewig merged commit c1146f1 into elastic:master Nov 14, 2019
@jrodewig jrodewig deleted the reformat-lic-api branch November 14, 2019 13:00
jrodewig added a commit that referenced this pull request Nov 14, 2019
Makes a few changes to better align the update license API docs with
the [API reference template][0].

Changes:

* Replaces POST with PUT in several snippet examples.
  While both are valid, PUT is a bit more RESTful.

* Removes leading slashes (/) from all snippets.

* Relocates and retitles the 'Authorization' section to 'Prerequisites'.

* Replaces explicit titles with the appropriate API reference template
  attributes.

* Replaces unneeded `[float]` tags with explicit anchors.

Closes #35341

[0]: https://github.com/elastic/docs/blob/master/shared/api-ref-ex.asciidoc
jrodewig added a commit that referenced this pull request Nov 14, 2019
Makes a few changes to better align the update license API docs with
the [API reference template][0].

Changes:

* Replaces POST with PUT in several snippet examples.
  While both are valid, PUT is a bit more RESTful.

* Removes leading slashes (/) from all snippets.

* Relocates and retitles the 'Authorization' section to 'Prerequisites'.

* Replaces explicit titles with the appropriate API reference template
  attributes.

* Replaces unneeded `[float]` tags with explicit anchors.

Closes #35341

[0]: https://github.com/elastic/docs/blob/master/shared/api-ref-ex.asciidoc
jrodewig added a commit that referenced this pull request Nov 14, 2019
Makes a few changes to better align the update license API docs with
the [API reference template][0].

Changes:

* Replaces POST with PUT in several snippet examples.
  While both are valid, PUT is a bit more RESTful.

* Removes leading slashes (/) from all snippets.

* Relocates and retitles the 'Authorization' section to 'Prerequisites'.

* Replaces explicit titles with the appropriate API reference template
  attributes.

* Replaces unneeded `[float]` tags with explicit anchors.

Closes #35341

[0]: https://github.com/elastic/docs/blob/master/shared/api-ref-ex.asciidoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Security/License License functionality for commercial features v7.4.3 v7.6.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation clarification around PUT or POST for _xpack/license API
5 participants