-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[DOCS] Update doc_values documentation #49041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @TonioGarcia07, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in your Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile? |
Pinging @elastic/es-search (:Search/Mapping) |
Pinging @elastic/es-docs (>docs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @TonioGarcia07, generally looks good to me, can you also add the recently introduced annotated_text
field to the list which, looking at the code, also doesn't support doc_values?
According to https://kb.objectrocket.com/elasticsearch/when-to-use-the-keyword-type-vs-text-datatype-in-elasticsearch, the `string` type (with option `analyzed`) has been replaced by `text` after `6.0` (This version is 7.4) The `annonated_text` field do not support doc values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TonioGarcia07 thanks for the update, will run our docs CI tests before merging.
@elasticmachine test this please |
The `string` type (with option `analyzed`) has been replaced by `text` after `6.0`, also the `annonated_text` field do not support doc values and should be mentioned.
The `string` type (with option `analyzed`) has been replaced by `text` after `6.0`, also the `annonated_text` field do not support doc values and should be mentioned.
The `string` type (with option `analyzed`) has been replaced by `text` after `6.0`, also the `annonated_text` field do not support doc values and should be mentioned.
According to https://kb.objectrocket.com/elasticsearch/when-to-use-the-keyword-type-vs-text-datatype-in-elasticsearch, the
string
type (with optionanalyzed
) has been replaced bytext
after6.0
(This version is 7.4)gradle check
?