Skip to content

[DOCS] Update doc_values documentation #49041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Conversation

antoinewg
Copy link
Contributor

According to https://kb.objectrocket.com/elasticsearch/when-to-use-the-keyword-type-vs-text-datatype-in-elasticsearch, the string type (with option analyzed) has been replaced by text after 6.0 (This version is 7.4)

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@ghost
Copy link

ghost commented Nov 13, 2019

Hi @TonioGarcia07, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in your Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@antoinewg antoinewg changed the base branch from master to 7.4 November 13, 2019 14:11
@antoinewg antoinewg changed the base branch from 7.4 to master November 13, 2019 14:11
@antoinewg antoinewg changed the title Update doc_values doc [DOCS] Update doc_values documentation Nov 13, 2019
@cbuescher cbuescher added :Search Foundations/Mapping Index mappings, including merging and defining field types >docs General docs changes labels Nov 13, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Mapping)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TonioGarcia07, generally looks good to me, can you also add the recently introduced annotated_text field to the list which, looking at the code, also doesn't support doc_values?

@cbuescher cbuescher self-assigned this Nov 18, 2019
According to https://kb.objectrocket.com/elasticsearch/when-to-use-the-keyword-type-vs-text-datatype-in-elasticsearch, the `string` type (with option `analyzed`) has been replaced by `text` after `6.0` (This version is 7.4)

The `annonated_text` field do not support doc values
Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TonioGarcia07 thanks for the update, will run our docs CI tests before merging.

@cbuescher
Copy link
Member

@elasticmachine test this please

@cbuescher cbuescher merged commit 529ebea into elastic:master Nov 18, 2019
cbuescher pushed a commit that referenced this pull request Nov 18, 2019
The `string` type (with option `analyzed`) has been replaced by `text` after `6.0`, 
also the `annonated_text` field do not support doc values and should be mentioned.
cbuescher pushed a commit that referenced this pull request Nov 18, 2019
The `string` type (with option `analyzed`) has been replaced by `text` after `6.0`, 
also the `annonated_text` field do not support doc values and should be mentioned.
cbuescher pushed a commit that referenced this pull request Nov 18, 2019
The `string` type (with option `analyzed`) has been replaced by `text` after `6.0`, 
also the `annonated_text` field do not support doc values and should be mentioned.
@jimczi jimczi added v7.5.0 and removed v7.5.1 labels Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types v7.4.3 v7.5.0 v7.6.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants