[ML][Inference] changing setting to be memorySizeSettting #49259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml) |
benwtrent
force-pushed
the
feature/ml-inference-validate-model-cache-setting
branch
from
ba67ce1 to
4b52cbe
Compare
|
run elasticsearch-ci/packaging-sample-matrix |
|
I noticed this setting isn't in the docs. Please can you add it. (You can do this in a subsequent PR so this one can be merged while it's green.) |
benwtrent
deleted the
feature/ml-inference-validate-model-cache-setting
branch
benwtrent
added a commit
that referenced
this pull request
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While going through the settings and experimenting, I found that having
xpack.ml.inference_model.cache_sizestrictly be a byteSized value to be problematic.What if the user provides a byte sized value that is more than the heap?
What if the heap of the node is less than the default value?
Having it as a
memorySizeSettingallows users and us to set the value as a percentage of heap or a static bytesized value.