Add support for geometrycollections to GeometryTreeReader and Writer #49608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for multi shapes and geometry collections to GeometryTreeReader and GeometryTreeWriter. Relates elastic#37206
imotov
added
the
:Analytics/Geo
|
Pinging @elastic/es-analytics-geo (:Analytics/Geo) |
talevy
reviewed
Nov 26, 2019
server/src/main/java/org/elasticsearch/common/geo/GeometryTreeReader.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/common/geo/GeometryTreeWriter.java
Show resolved
Hide resolved
talevy
reviewed
Nov 26, 2019
There was a problem hiding this comment.
Generally looks good to me, I just realized something about the nestedness of geometry-collection and wanted to be sure we are consistent here with regards to what we allow, and how we parse.
a side-note about the geometrycollection is that if someone indexes a geometry-collection with one item that is a geometrycollection, then we would be duplicating the centroids here as well.
server/src/main/java/org/elasticsearch/common/geo/GeometryTreeReader.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/common/geo/GeometryTreeWriter.java
Show resolved
Hide resolved
|
Do you think we can do centroid optimization everywhere in another pass? |
yes. that is reasonable! |
talevy
approved these changes
Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support geometry collections to GeometryTreeReader
and GeometryTreeWriter.
Relates #37206