Skip to content

Add Lucene directory and index input implementations that expose shard snapshot #49651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 13, 2019
Merged

Add Lucene directory and index input implementations that expose shard snapshot #49651

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5b3960d
SearchableSnapshotDirectory
tlrx Nov 26, 2019
e2438cb
few adjustments
tlrx Dec 11, 2019
d450eca
Merge branch 'feature/searchable-snapshots' into searchable-snapshots…
tlrx Dec 11, 2019
dce4808
Apply suggestions from code review
tlrx Dec 12, 2019
309a706
Apply feedback
tlrx Dec 12, 2019
8ad7174
Add missing setting
tlrx Dec 13, 2019
a2de0d2
random seeking
tlrx Dec 13, 2019
9cba9a9
override output value so we can check the random read succeded
tlrx Dec 13, 2019
5c2bd1a
Merge branch 'feature/searchable-snapshots' into searchable-snapshots…
elasticmachine Dec 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions ...pshots/src/main/java/org/elasticsearch/xpack/searchablesnapshots/SearchableSnapshots.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,18 @@
*/
public class SearchableSnapshots extends Plugin implements IndexStorePlugin, RepositoryPlugin {

public static final Setting<String> EPHEMERAL_INDEX_REPOSITORY_SETTING =
public static final Setting<String> SNAPSHOT_REPOSITORY_SETTING =
Setting.simpleString("index.store.snapshot.repository_name", Setting.Property.IndexScope, Setting.Property.PrivateIndex);

public static final Setting<String> EPHEMERAL_INDEX_SNAPSHOT_SETTING =
public static final Setting<String> SNAPSHOT_SNAPSHOT_NAME_SETTING =
Setting.simpleString("index.store.snapshot.snapshot_name", Setting.Property.IndexScope, Setting.Property.PrivateIndex);

public static final Setting<String> SNAPSHOT_SNAPSHOT_ID_SETTING =
Setting.simpleString("index.store.snapshot.snapshot_uuid", Setting.Property.IndexScope, Setting.Property.PrivateIndex);

public static final Setting<String> SNAPSHOT_INDEX_ID_SETTING =
Setting.simpleString("index.store.snapshot.index_uuid", Setting.Property.IndexScope, Setting.Property.PrivateIndex);

private final SetOnce<RepositoriesService> repositoriesService;
private final SetOnce<ThreadPool> threadPool;

Expand All @@ -55,7 +61,7 @@ public SearchableSnapshots() {

@Override
public List<Setting<?>> getSettings() {
return List.of(EPHEMERAL_INDEX_REPOSITORY_SETTING, EPHEMERAL_INDEX_SNAPSHOT_SETTING);
return List.of(SNAPSHOT_REPOSITORY_SETTING, SNAPSHOT_SNAPSHOT_ID_SETTING, SNAPSHOT_INDEX_ID_SETTING);
}

@Override
Expand Down Expand Up @@ -89,16 +95,18 @@ public static DirectoryFactory newDirectoryFactory(final Supplier<RepositoriesSe
final RepositoriesService repositories = repositoriesService.get();
assert repositories != null;

final Repository repository = repositories.repository(EPHEMERAL_INDEX_REPOSITORY_SETTING.get(indexSettings.getSettings()));
final Repository repository = repositories.repository(SNAPSHOT_REPOSITORY_SETTING.get(indexSettings.getSettings()));
if (repository instanceof BlobStoreRepository == false) {
throw new IllegalArgumentException("Repository [" + repository + "] does not support searchable snapshots" );
}

BlobStoreRepository blobStoreRepository = (BlobStoreRepository) repository;
BlobContainer blobContainer = blobStoreRepository.shardContainer(new IndexId(indexSettings.getIndex().getName(),
shardPath.getShardId().getIndex().getUUID()), shardPath.getShardId().id());
BlobStoreIndexShardSnapshot snapshot = blobStoreRepository.loadShardSnapshot(blobContainer,
new SnapshotId("_ephemeral", EPHEMERAL_INDEX_SNAPSHOT_SETTING.get(indexSettings.getSettings())));
IndexId indexId = new IndexId(indexSettings.getIndex().getName(), SNAPSHOT_INDEX_ID_SETTING.get(indexSettings.getSettings()));
BlobContainer blobContainer = blobStoreRepository.shardContainer(indexId, shardPath.getShardId().id());

SnapshotId snapshotId = new SnapshotId(SNAPSHOT_SNAPSHOT_NAME_SETTING.get(indexSettings.getSettings()),
SNAPSHOT_SNAPSHOT_ID_SETTING.get(indexSettings.getSettings()));
BlobStoreIndexShardSnapshot snapshot = blobStoreRepository.loadShardSnapshot(blobContainer, snapshotId);

return new SearchableSnapshotDirectory(snapshot, blobContainer);
};
Expand Down
Loading