Move BuildParams class to 'minimumRuntime' source set #49890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tibility with build-tools for builds using a Java 8 runtime. Closes elastic#49766 Signed-off-by: Mark Vieira <[email protected]>
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
|
FYI, this is being done in |
|
@elasticmachine run elasticsearch-ci/1 |
rjernst
approved these changes
Dec 5, 2019
| @@ -155,6 +154,7 @@ public void reset() { | |||
| .filter(f -> Modifier.isStatic(f.getModifiers())) | |||
| .forEach(f -> { | |||
| try { | |||
| f.setAccessible(true); | |||
There was a problem hiding this comment.
can you please add a comment explaining why this is needed?
There was a problem hiding this comment.
I've added a comment to explain the need for this.
Signed-off-by: Mark Vieira <[email protected]>
mark-vieira
added a commit
that referenced
this pull request
Dec 6, 2019
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
Move BuildParams class to 'minimumRuntime' source set to retain compatibility with build-tools for builds using a Java 8 runtime. Closes elastic#49766
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves BuildParams and dependent classes to the 'minimumRuntime' source set in order to maintain backwards compatibility with build-tools for builds using a Java 8 runtime.
Closes #49766