Skip to content

A few improvements to AnalyticsProcessManager class that make the code more readable. #50026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 11, 2019
Merged

A few improvements to AnalyticsProcessManager class that make the code more readable. #50026

merged 3 commits into from
Dec 11, 2019

Conversation

przemekwitek
Copy link
Contributor

@przemekwitek przemekwitek commented Dec 10, 2019 •
edited
Loading

This PR implements a few improvements to the AnalyticsProcessManager class:

  1. inline finishHandler into AnalyticsProcessManager class so that all the interactions with task are clearly visible
  2. Make use of SetOnce wrappers in ProcessContext
  3. Store config in ProcessContext so that config does not have to be passed around

Relates #49680

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

dimitris-athanasiou
dimitris-athanasiou approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Just a suggestion to add a logging message.

@przemekwitek
Copy link
Contributor Author

run elasticsearch-ci/bwc
run elasticsearch-ci/default-distro

@przemekwitek
Copy link
Contributor Author

run elasticsearch-ci/packaging-sample-matrix

@przemekwitek przemekwitek merged commit 022e5f5 into elastic:master Dec 11, 2019
@przemekwitek przemekwitek deleted the reduce_locking branch December 11, 2019 07:50
@przemekwitek przemekwitek mentioned this pull request Dec 11, 2019
Merged
przemekwitek added a commit that referenced this pull request Dec 11, 2019
@przemekwitek
A few improvements to AnalyticsProcessManager class that make the cod…
9b116c8 
…e more readable. (#50026) (#50069)
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
@przemekwitek @SivagurunathanV
A few improvements to AnalyticsProcessManager class that make the cod…
d8d90b6 
…e more readable. (elastic#50026)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitris-athanasiou dimitris-athanasiou dimitris-athanasiou approved these changes

Assignees
No one assigned
Labels
:ml Machine learning >refactoring v7.6.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@przemekwitek @elasticmachine @dimitris-athanasiou @jakelandis