Skip to content

[DOCS] Warn about using geo_centroid as sub-agg to geohash_grid #50038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 6, 2020
Merged

[DOCS] Warn about using geo_centroid as sub-agg to geohash_grid #50038

merged 2 commits into from
Jan 6, 2020

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Dec 10, 2019

If geo_point fields are multi-valued, using geo_centroid as a sub-agg to geohash_grid could result in centroids outside of bucket boundaries.

This adds a related warning to the geo_centroid agg docs.

Closes #49189.

@jrodewig jrodewig added >docs General docs changes :Analytics/Geo Indexing, search aggregations of geo points and shapes v8.0.0 v7.6.0 v7.5.1 labels Dec 10, 2019
@jrodewig jrodewig requested review from nknize and cbuescher December 10, 2019 16:16
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Geo)

If `geo_point fields` are multi-valued, using `geo_centroid` as a
sub-agg to `geohash_grid` could result in centroids outside of bucket
boundaries.

This adds a related warning to the geo_centroid agg docs.
@jrodewig jrodewig requested a review from iverase December 10, 2019 17:03
@jrodewig
Copy link
Contributor Author

@elasticmachine update branch

Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrodewig jrodewig merged commit 7f35bcd into elastic:master Jan 6, 2020
@jrodewig jrodewig deleted the geohash-centroid-warning branch January 6, 2020 13:45
jrodewig added a commit that referenced this pull request Jan 6, 2020
…50038)

If `geo_point fields` are multi-valued, using `geo_centroid` as a
sub-agg to `geohash_grid` could result in centroids outside of bucket
boundaries.

This adds a related warning to the geo_centroid agg docs.
jrodewig added a commit that referenced this pull request Jan 6, 2020
…50038)

If `geo_point fields` are multi-valued, using `geo_centroid` as a
sub-agg to `geohash_grid` could result in centroids outside of bucket
boundaries.

This adds a related warning to the geo_centroid agg docs.
@jrodewig
Copy link
Contributor Author

jrodewig commented Jan 6, 2020

Backport commits

master: 7f35bcd
7.x: 1299dda
7.5: e881dc2

@jrodewig
Copy link
Contributor Author

jrodewig commented Jan 6, 2020

Thanks for the review @cbuescher!

SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
…lastic#50038)

If `geo_point fields` are multi-valued, using `geo_centroid` as a
sub-agg to `geohash_grid` could result in centroids outside of bucket
boundaries.

This adds a related warning to the geo_centroid agg docs.
@jakelandis jakelandis removed the v8.0.0 label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >docs General docs changes v7.5.2 v7.6.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Problems with using geocentroid for multi-valued geo_points
5 participants