Omit loading IndexMetaData when inspecting shards #50214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywelsch
added
>non-issue
:Distributed Coordination/Allocation
|
Pinging @elastic/es-distributed (:Distributed/Allocation) |
server/src/main/java/org/elasticsearch/gateway/TransportNodesListGatewayStartedShards.java
Show resolved
Hide resolved
original-brownbear
approved these changes
Dec 16, 2019
server/src/main/java/org/elasticsearch/gateway/TransportNodesListGatewayStartedShards.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/gateway/TransportNodesListGatewayStartedShards.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/indices/store/TransportNodesListShardStoreMetaData.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/indices/store/TransportNodesListShardStoreMetaData.java
Show resolved
Hide resolved
DaveCTurner
approved these changes
Dec 17, 2019
server/src/main/java/org/elasticsearch/gateway/TransportNodesListGatewayStartedShards.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/indices/store/TransportNodesListShardStoreMetaData.java
Show resolved
Hide resolved
ywelsch
added a commit
that referenced
this pull request
Dec 17, 2019
ywelsch
added a commit
that referenced
this pull request
Dec 17, 2019
Loading shard state information during shard allocation sometimes runs into a situation where a data node does not know yet how to look up the shard on disk if custom data paths are used. The current implementation loads the index metadata from disk to determine what the custom data path looks like. This PR removes this dependency, simplifying the lookup. Relates #48701
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
Loading shard state information during shard allocation sometimes runs into a situation where a data node does not know yet how to look up the shard on disk if custom data paths are used. The current implementation loads the index metadata from disk to determine what the custom data path looks like. This PR removes this dependency, simplifying the lookup. Relates elastic#48701
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading shard state information during shard allocation sometimes runs into a situation where a data node does not know yet how to look up the shard on disk if custom data paths are used. The current implementation loads the index metadata from disk to determine what the custom data path looks like. This PR removes this dependency, simplifying the lookup.
Relates #48701 but this PR is against master, as it has direct benefits even without the changes in #48701.