Skip to content

Specify name on enrich.get_policy as list type #50217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2020
Merged

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Dec 16, 2019

This PR updates the enrich.get_policy API to specify name as a list, in line with other URL parts that accept a comma-separated list of values

This commit updates the enrich.get_policy API to specify name
as a list, in line with other URL parts that accept a comma-separated
list of values
This commit updates the get enrich policy API docs
to align the URL part name in the documentation with
the name used in the REST API specs.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Features)

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russcam russcam merged commit 94f6f94 into master Feb 20, 2020
russcam added a commit that referenced this pull request Feb 20, 2020
This commit updates the enrich.get_policy API to specify name
as a list, in line with other URL parts that accept a comma-separated
list of values.

In addition, update the get enrich policy API docs
to align the URL part name in the documentation with
the name used in the REST API specs.

(cherry picked from commit 94f6f94)
russcam added a commit that referenced this pull request Feb 20, 2020
This commit updates the enrich.get_policy API to specify name
as a list, in line with other URL parts that accept a comma-separated
list of values.

In addition, update the get enrich policy API docs
to align the URL part name in the documentation with
the name used in the REST API specs.

(cherry picked from commit 94f6f94)
@russcam
Copy link
Contributor Author

russcam commented Feb 20, 2020

thanks @martijnvg . backported to 7.x and 7.6

@russcam russcam deleted the russcam-patch-1-1 branch February 20, 2020 01:41
@martijnvg
Copy link
Member

thanks @russcam!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants