[ML][Inference] fix support for nested fields #50258
Conversation
|
Pinging @elastic/ml-core (:ml) |
| @@ -128,7 +129,7 @@ void handleResponse(InternalInferModelAction.Response response, | |||
| Map<String, Object> fields = new HashMap<>(ingestDocument.getSourceAndMetadata()); | |||
| if (fieldMapping != null) { | |||
| fieldMapping.forEach((src, dest) -> { | |||
| Object srcValue = fields.remove(src); | |||
There was a problem hiding this comment.
This is not the same as src is left in the fields map. I don't think it matters in terms of the logic only that a larger map than is necessary it being passed around.
There was a problem hiding this comment.
@davidkyle I suppose. This would require the dig method to have a sister "remove" method. For simplicity I opted not to include it. Having a larger map passed around is pretty cheap right now. We may have issues ones we support more than a ~100 features.
| * "a.b.c": {"d": 2} | ||
| * } | ||
| * | ||
| * To exhaustively explore all these paths would result in 2^n-1 total possible paths, where {@code n = path.split("\\.").length} |
There was a problem hiding this comment.
By possible paths you mean ways of constructing the equivalent path a.b.c.d where each element could be a nested object or a string containing '.'. And the 2^n-1 comes from the observation that each separator in the path could either be a '.' or a nested object (':') i.e. one of two choices and there are n-1 separators.
Could you make the comment a bit clearer please.
…m:benwtrent/elasticsearch into feature/ml-inference-handle-nested-fields
|
run elasticsearch-ci/2 |
|
@elasticmachine update branch |
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/utils/MapHelper.java
Outdated
Show resolved
Hide resolved
…ml/utils/MapHelper.java Co-Authored-By: David Kyle <[email protected]>
This fixes support for nested fields We now support fully nested, fully collapsed, or a mix of both on inference docs. ES mappings allow the `_source` to be any combination of nested objects + dot delimited fields. So, we should do our best to find the best path down the Map for the desired field.
This fixes support for nested fields We now support fully nested, fully collapsed, or a mix of both on inference docs. ES mappings allow the `_source` to be any combination of nested objects + dot delimited fields. So, we should do our best to find the best path down the Map for the desired field.
This fixes support for nested fields We now support fully nested, fully collapsed, or a mix of both on inference docs. ES mappings allow the `_source` to be any combination of nested objects + dot delimited fields. So, we should do our best to find the best path down the Map for the desired field.
This fixes support for nested fields
We now support fully nested, fully collapsed, or a mix of both on inference docs.
ES mappings allow the
_sourceto be any combination of nested objects + dot delimited fields.So, we should do our best to find the best path down the Map to
Examples: