Skip to content

Rename the remote connection mode simple to proxy #50291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 19, 2019
Merged

Rename the remote connection mode simple to proxy #50291

merged 4 commits into from
Dec 19, 2019

Conversation

Tim-Brooks
Copy link
Contributor

@Tim-Brooks Tim-Brooks commented Dec 17, 2019 •
edited
Loading

This commit renames the simple connection mode to the proxy connection
mode for remote cluster connections. In order to do this, the mode specific
settings which we namespaced by their mode (ex: sniff.seed and
proxy.addresses) have been reverted.

@Tim-Brooks
Rename the remote connection mode "simple" to proxy
1b27979 
This commit renames the simple connection mode to the proxy connection
mode for remote cluster connections.
@Tim-Brooks Tim-Brooks added >non-issue :Distributed Coordination/Network Http and internode communication implementations v8.0.0 v7.6.0 labels Dec 17, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Network)

@Tim-Brooks Tim-Brooks changed the title Rename the remote connection mode "simple" to proxy Rename the remote connection mode simple to proxy Dec 17, 2019
@Tim-Brooks Tim-Brooks mentioned this pull request Dec 18, 2019
Closed
@Tim-Brooks
Copy link
Contributor Author

@ywelsch @jasontedor

As I described in the other PR, using the name proxy prevents us from implementing settings such as cluster.remote.cluster_name.proxy.addresses because the setting cluster.remote.cluster_name.proxy already exists.

This PR reverts the changes to put the mode in the setting name. The settings are now:

cluster.remote.cluster_name.sniff.seeds -> cluster.remote.cluster_name.seeds

cluster.remote.cluster_name.sniff.node_connections -> cluster.remote.cluster_name.node_connections

cluster.remote.cluster_name.proxy.addresses -> cluster.remote.cluster_name.proxy_addresses

cluster.remote.cluster_name.proxy.socket_connections -> cluster.remote.cluster_name.proxy_socket_connections

cluster.remote.cluster_name.proxy.include_server_name -> cluster.remote.cluster_name.include_server_name

There is still extensive validation to ensure that an irrelevant setting cannot be applied if it does not conform to the existing mode.

Finally, after discussion Jason and I decided to move from multiple addresses to a single proxy address. However, this will be implemented in a follow-up.

ywelsch
ywelsch approved these changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tim-Brooks Tim-Brooks merged commit 342a292 into elastic:master Dec 19, 2019
Tim-Brooks added a commit to Tim-Brooks/elasticsearch that referenced this pull request Dec 19, 2019
@Tim-Brooks
Rename the remote connection mode simple to proxy (elastic#50291)
c3f06f6 
This commit renames the simple connection mode to the proxy connection
mode for remote cluster connections. In order to do this, the mode specific
settings which we namespaced by their mode (ex: sniff.seed and
proxy.addresses) have been reverted.
@Tim-Brooks Tim-Brooks mentioned this pull request Dec 19, 2019
Merged
Tim-Brooks added a commit that referenced this pull request Dec 20, 2019
@Tim-Brooks
Backport remote proxy mode stats and naming (#50402)
cb73fb0 
* Update remote cluster stats to support simple mode (#49961)

Remote cluster stats API currently only returns useful information if
the strategy in use is the SNIFF mode. This PR modifies the API to
provide relevant information if the user is in the SIMPLE mode. This
information is the configured addresses, max socket connections, and
open socket connections.

* Send hostname in SNI header in simple remote mode (#50247)

Currently an intermediate proxy must route conncctions to the
appropriate remote cluster when using simple mode. This commit offers
a additional mechanism for the proxy to route the connections by
including the hostname in the TLS SNI header.

* Rename the remote connection mode simple to proxy (#50291)

This commit renames the simple connection mode to the proxy connection
mode for remote cluster connections. In order to do this, the mode specific
settings which we namespaced by their mode (ex: sniff.seed and
proxy.addresses) have been reverted.

* Modify proxy mode to support a single address (#50391)

Currently, the remote proxy connection mode uses a list setting for the
proxy address. This commit modifies this so that the setting is
proxy_address and only supports a single remote proxy address.
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
@Tim-Brooks @SivagurunathanV
Rename the remote connection mode simple to proxy (elastic#50291)
f85f769 
This commit renames the simple connection mode to the proxy connection
mode for remote cluster connections. In order to do this, the mode specific
settings which we namespaced by their mode (ex: sniff.seed and
proxy.addresses) have been reverted.
@Tim-Brooks Tim-Brooks deleted the remote_cluster_reename_to_proxy branch April 30, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywelsch ywelsch ywelsch approved these changes

@jasontedor jasontedor Awaiting requested review from jasontedor

Assignees
No one assigned
Labels
:Distributed Coordination/Network Http and internode communication implementations >non-issue v7.6.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tim-Brooks @elasticmachine @ywelsch @jakelandis