Skip to content

Convert main README to asciidoc #50303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 19, 2019

Conversation

spinscale
Copy link
Contributor

Some minor changes along the way

  • Mentioning Slack instead of IRC
  • Removed mentioning of native java API, HTTP should be used
  • Removed java as a installed requirement

Some minor changes along the way

* Mentioning Slack instead of IRC
* Removed mentioning of native java API, HTTP should be used
* Removed java as a installed requirement
@jtibshirani jtibshirani added :Core/Infra/Core Core issues without another label >docs General docs changes labels Dec 19, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Core)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one minor nit re: OS names but otherwise LGTM.

@jrodewig
Copy link
Contributor

@elasticmachine run elasticsearch-ci/packaging-sample-matrix-unix

@jrodewig
Copy link
Contributor

@elasticmachine run elasticsearch-ci/packaging-sample-matrix-windows

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jrodewig
Copy link
Contributor

@elasticmachine update branch

@jrodewig
Copy link
Contributor

I can't seem to get the packaging-sample CI tests to pass for this PR. However, I don't believe those tests are actually needed for these changes anyway.

I'll merge this. Thanks again @spinscale.

@jrodewig jrodewig merged commit 56cb357 into elastic:master Dec 19, 2019
jrodewig added a commit that referenced this pull request Dec 19, 2019
Converts the main README file to asciidoc.

Also includes the following changes:

* Mentioning Slack instead of IRC
* Removed mentioning of native java API, HTTP should be used
* Removed java as a installed requirement
jrodewig added a commit that referenced this pull request Dec 19, 2019
Converts the main README file to asciidoc.

Also includes the following changes:

* Mentioning Slack instead of IRC
* Removed mentioning of native java API, HTTP should be used
* Removed java as a installed requirement
@jrodewig
Copy link
Contributor

master: 56cb357
7.x: 6fc7868
7.5: 548f209

SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
Converts the main README file to asciidoc.

Also includes the following changes:

* Mentioning Slack instead of IRC
* Removed mentioning of native java API, HTTP should be used
* Removed java as a installed requirement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label >docs General docs changes v7.5.2 v7.6.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants