-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[ML] Adds support for a global calendars #50372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
benwtrent
merged 5 commits into
elastic:master
from
benwtrent:feature/ml-allow-global-calendar
Feb 20, 2020
Merged
[ML] Adds support for a global calendars #50372
benwtrent
merged 5 commits into
elastic:master
from
benwtrent:feature/ml-allow-global-calendar
Feb 20, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/ml-core (:ml) |
@elasticmachine update branch |
droberts195
approved these changes
Dec 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
benwtrent
commented
Dec 19, 2019
...plugin/ml/src/main/java/org/elasticsearch/xpack/ml/job/persistence/CalendarQueryBuilder.java
Outdated
Show resolved
Hide resolved
…nt/elasticsearch into feature/ml-allow-global-calendar
Currently blocked by: elastic/kibana#53604 |
4 tasks
@elasticmachine update branch |
_all
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Feb 20, 2020
This adds `_all` to Calendar searches. This enables users to supply the `_all` string in the `job_ids` array when creating a Calendar. That calendar will now be applied to all jobs (existing and newly created). Closes elastic#45013
benwtrent
added a commit
that referenced
this pull request
Feb 20, 2020
This adds `_all` to Calendar searches. This enables users to supply the `_all` string in the `job_ids` array when creating a Calendar. That calendar will now be applied to all jobs (existing and newly created). Closes #45013 Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
_all
to Calendar searches. This enables users to supply the_all
string in thejob_ids
array when creating a Calendar. That calendar will now be applied to all jobs (existing and newly created).Closes #45013