Skip to content

Mark some constants in decay functions final (backport of #50569) #50575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ public abstract class DecayFunctionBuilder<DFB extends DecayFunctionBuilder<DFB>
protected static final String DECAY = "decay";
protected static final String OFFSET = "offset";

public static double DEFAULT_DECAY = 0.5;
public static MultiValueMode DEFAULT_MULTI_VALUE_MODE = MultiValueMode.MIN;
public static final double DEFAULT_DECAY = 0.5;
public static final MultiValueMode DEFAULT_MULTI_VALUE_MODE = MultiValueMode.MIN;

private final String fieldName;
//parsing of origin, scale, offset and decay depends on the field type, delayed to the data node that has the mapping for it
Expand Down